Skip to content

Modernize GitHub links pinned to commit SHAs - #5012

Merged
Duncanma merged 3 commits into
mainfrom
duncan/github-links-commit-shas-f5b04a
Aug 3, 2026
Merged

Modernize GitHub links pinned to commit SHAs#5012
Duncanma merged 3 commits into
mainfrom
duncan/github-links-commit-shas-f5b04a

Conversation

@Duncanma

@Duncanma Duncanma commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Summary

Follow-up to an earlier GitHub link sweep that intentionally skipped ~40 links pinned to commit SHAs, since many carry line anchors (#L108) that drift and would silently point at the wrong line if just moved to main.

  • Links without a line anchor (20): repointed to the repo's default branch (main, or master for grpc/grpc). Two of these had moved to a new path along the way, so the link target was updated accordingly:
    • cloud-samples-go's client/api/apikey.go was merged into client/api/client.go.
    • ui's server/docker/config-template.yaml moved to server/config/docker.yaml.
  • Links with a line anchor (20): fetched the original pinned snapshot to identify exactly what each anchor pointed at, located that same declaration in the current default-branch HEAD, and re-pinned to today's commit SHA with the corrected line number. Several had moved files entirely, e.g. temporal's history size/count limit defaults moved from service/history/configs/config.go into common/dynamicconfig/constants.go, and common/metrics/defs.gometric_defs.go.

Test plan

  • Verified every re-pinned line by diffing the old pinned snapshot against the new HEAD content for each file
  • vale --config .vale-ci.ini docs/ on all touched files — 0 errors/warnings (pre-existing heading-style suggestions only, unrelated to this change)
  • Confirmed no remaining commit-SHA-pinned links in docs/ outside the one flagged item

┆Attachments: EDU-6866 Modernize GitHub links pinned to commit SHAs

Unpin links without line anchors to the repo's default branch (main/master),
fixing two that had moved to new paths along the way. Re-verify and re-pin
links with line anchors to the current default-branch commit, correcting
line numbers where the referenced code has moved.
@vercel

vercel Bot commented Aug 1, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
temporal-documentation Ready Ready Preview Aug 3, 2026 4:24pm

Request Review

[Cloud Samples in Go](https://github.com/temporalio/cloud-samples-go/blob/1dd4254b6ed1937e361005c0144410e72b8a5542/client/api/apikey.go).
[Cloud Samples in Go](https://github.com/temporalio/cloud-samples-go/blob/main/client/api/client.go).

### Terraform Provider

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [vale] reported by reviewdog 🐶
[Temporal.Headings] 'Terraform Provider' should use sentence-style capitalization.

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

✅ Docs build passed

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

📖 Docs PR preview links

@Duncanma
Duncanma marked this pull request as ready for review August 3, 2026 16:20
@Duncanma
Duncanma requested a review from a team as a code owner August 3, 2026 16:20
@Duncanma
Duncanma merged commit 06e4627 into main Aug 3, 2026
14 checks passed
@Duncanma
Duncanma deleted the duncan/github-links-commit-shas-f5b04a branch August 3, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants